Skip to content

Kokkos Automatic Differentiation (Undisplaced)#32597

Merged
NamjaeChoi merged 14 commits into
idaholab:nextfrom
NamjaeChoi:kokkos_ad
May 19, 2026
Merged

Kokkos Automatic Differentiation (Undisplaced)#32597
NamjaeChoi merged 14 commits into
idaholab:nextfrom
NamjaeChoi:kokkos_ad

Conversation

@NamjaeChoi
Copy link
Copy Markdown
Contributor

@NamjaeChoi NamjaeChoi commented Apr 1, 2026 •
edited
Loading

Refs #32699.

@NamjaeChoi NamjaeChoi changed the title [WIP] Kokkos Automatic Differentation [WIP] Kokkos Automatic Differentiation (Undisplaced) Apr 1, 2026
@NamjaeChoi NamjaeChoi moved this to In progress in NEAMS MP CONNECT/GPU 26 Apr 2, 2026
@NamjaeChoi NamjaeChoi force-pushed the kokkos_ad branch 2 times, most recently from 1e1ea85 to 9e48e13 Compare April 2, 2026 20:01
@NamjaeChoi NamjaeChoi changed the title [WIP] Kokkos Automatic Differentiation (Undisplaced) Kokkos Automatic Differentiation (Undisplaced) Apr 2, 2026
@moosebuild
Copy link
Copy Markdown
Contributor

moosebuild commented Apr 2, 2026 •
edited
Loading

Job Documentation, step Docs: sync website on 28bde29 wanted to post the following:

View the site here

This comment will be updated on new commits.

@NamjaeChoi NamjaeChoi force-pushed the kokkos_ad branch 4 times, most recently from e09c807 to 50259af Compare April 3, 2026 15:30
@idaholab idaholab deleted a comment from moosebuild Apr 13, 2026
@NamjaeChoi NamjaeChoi force-pushed the kokkos_ad branch 4 times, most recently from be28b83 to c18bb1b Compare April 21, 2026 21:53
@idaholab idaholab deleted a comment from moosebuild Apr 21, 2026
@NamjaeChoi NamjaeChoi marked this pull request as ready for review April 22, 2026 04:01
@NamjaeChoi NamjaeChoi force-pushed the kokkos_ad branch 3 times, most recently from 17b218d to a8ac7f0 Compare April 22, 2026 14:49
@NamjaeChoi NamjaeChoi requested a review from cticenhour as a code owner April 22, 2026 14:49
@lindsayad
Copy link
Copy Markdown
Member

lindsayad commented May 13, 2026

could we maybe build some unit tests to bring down the 140 unused lines introduced in Coupleable?

lindsayad
lindsayad reviewed May 13, 2026
View reviewed changes
Comment thread framework/doc/content/syntax/KokkosKernels/index.md Outdated
Comment thread framework/doc/content/syntax/KokkosKernels/index.md Outdated
Comment thread framework/include/kokkos/base/KokkosJaggedArray.h
Comment thread framework/include/kokkos/base/KokkosResidualObject.h
Comment thread framework/include/kokkos/base/KokkosResidualObject.h
Comment thread framework/include/kokkos/systems/KokkosSystem.h Outdated
Comment thread framework/include/kokkos/systems/KokkosSystem.h Outdated
Comment thread test/tests/kokkos/kernels/ad_diffusion/tests Outdated
Comment thread test/tests/kokkos/kernels/ad_time_derivative/tests Outdated
Comment thread test/tests/kokkos/kernels/ad_time_derivative/tests Outdated
@NamjaeChoi
Copy link
Copy Markdown
Contributor Author

NamjaeChoi commented May 14, 2026 •
edited
Loading

could we maybe build some unit tests to bring down the 140 unused lines introduced in Coupleable?

No, this requires the full problem to be built for testing. Hopefully we can get more coverage as the time goes on and more tests get added.

@NamjaeChoi NamjaeChoi force-pushed the kokkos_ad branch 3 times, most recently from 6997568 to a2f3df9 Compare May 14, 2026 23:18
@moosebuild
Copy link
Copy Markdown
Contributor

moosebuild commented May 19, 2026

Job Test, step Results summary on 28bde29 wanted to post the following:

Framework test summary

Compared against d78fcfd in job civet.inl.gov/job/3833675.

Added tests

Test Time (s) Memory (MB)
kokkos/kernels/ad_time_derivative.test_jacobian 1.94 123.71
kokkos/kernels/ad_time_derivative.coupled_jacobian 1.07 133.82
kokkos/bcs/ad_coupled_var_neumann.nonlinear/jac 0.87 74.74
kokkos/bcs/ad_coupled_var_neumann.nonlinear/exo 0.81 128.14
kokkos/kernels/ad_diffusion.dirichlet 0.78 166.38
kokkos/kernels/ad_time_derivative.test 0.77 143.66
kokkos/kernels/ad_diffusion.jacobian 0.74 89.12
kokkos/bcs/ad_coupled_var_neumann.test 0.74 186.40
kokkos/kernels/ad_diffusion.neumann 0.69 106.65
kokkos/kernels/ad_time_derivative.coupled 0.67 92.57
kokkos/kernels/ad_time_derivative.separate 0.65 67.05

Modules test summary

Compared against d78fcfd in job civet.inl.gov/job/3833675.

No change

@NamjaeChoi
Copy link
Copy Markdown
Contributor Author

NamjaeChoi commented May 19, 2026

Failure unrelated

@NamjaeChoi NamjaeChoi merged commit 2687d7b into idaholab:next May 19, 2026
73 of 75 checks passed
@NamjaeChoi NamjaeChoi deleted the kokkos_ad branch May 19, 2026 20:08
@github-project-automation github-project-automation Bot moved this from In progress to Done in NEAMS MP CONNECT/GPU 26 May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lindsayad lindsayad lindsayad approved these changes

@joshuahansel joshuahansel Awaiting requested review from joshuahansel

@roystgnr roystgnr Awaiting requested review from roystgnr roystgnr is a code owner

@cticenhour cticenhour Awaiting requested review from cticenhour cticenhour is a code owner

Assignees

@NamjaeChoi NamjaeChoi

Labels

None yet

Projects

NEAMS MP CONNECT/GPU 26
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NamjaeChoi @moosebuild @lindsayad @roystgnr